Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid calling peekMeta when meta does not exist #17057

Closed
wants to merge 1 commit into from
Closed

avoid calling peekMeta when meta does not exist #17057

wants to merge 1 commit into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Oct 8, 2018 •
edited
Loading

differentiate between not passing meta and meta not existing.

many meta related functions allow passing meta as last argument and do check if meta passed as following:

let meta = _meta === undefined ? peekMeta(obj) : _meta;

is such case peekMeta() is called even if last argument is passed as undefined since meta does not exist, to avoid it made peekMeta to return null instead of undefined

@bekzod
Copy link
Contributor Author

bekzod commented Oct 8, 2018

closing this for now, it is typescript lint nightmare

@bekzod bekzod closed this Oct 8, 2018
@bekzod bekzod mentioned this pull request Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bekzod